[PATCH] D64785: [ADCE] Fix non-deterministic behaviour due to iterating over a pointer set

[Florian Hahn via Phabricator via llvm-commits]

fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

LGTM, thanks. We iterate over BlocksWithDeadTerminators later on, which can cause edges to BBs to be removed a different order.

I think you should add the test IR test, just pass and check `-preserve-ll-uselistorder`. There should be an upstream bot setting LLVM_REVERSE_ITERATION, which should result in a different use-list ordering without this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64785/new/

https://reviews.llvm.org/D64785