[PATCH] D64757: [PEI] Don't re-allocate a pre-allocated stack protector slot

John Brawn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 16 03:44:19 PDT 2019


john.brawn added a comment.

This will fix https://bugs.llvm.org/show_bug.cgi?id=25610, so it would be good if we could have a test for that as well (and to close that bug once this is committed).

This bug also affects the arm and powerpc targets (as they also return true for TargetRegisterInfo::requiresVirtualBaseRegisters), so it would be good to have tests for those as well. An example which affects all three targets (with -fomit-frame-pointer) is

  #include <string.h>
  #include <stdio.h>
  
  int fn(const char *str) {
    char buffer[65536];
    strcpy(buffer, str);
    puts(buffer);
    return buffer[65535];
  }


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64757/new/

https://reviews.llvm.org/D64757





More information about the llvm-commits mailing list