[lld] r366192 - [WebAssembly] Rename variale references in comments after VariableName -> variableName change

Fangrui Song via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 16 01:08:17 PDT 2019


Author: maskray
Date: Tue Jul 16 01:08:17 2019
New Revision: 366192

URL: http://llvm.org/viewvc/llvm-project?rev=366192&view=rev
Log:
[WebAssembly] Rename variale references in comments after VariableName -> variableName change

Modified:
    lld/trunk/wasm/InputFiles.cpp
    lld/trunk/wasm/MarkLive.cpp
    lld/trunk/wasm/SymbolTable.h
    lld/trunk/wasm/SyntheticSections.cpp
    lld/trunk/wasm/Writer.cpp

Modified: lld/trunk/wasm/InputFiles.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/wasm/InputFiles.cpp?rev=366192&r1=366191&r2=366192&view=diff
==============================================================================
--- lld/trunk/wasm/InputFiles.cpp (original)
+++ lld/trunk/wasm/InputFiles.cpp Tue Jul 16 01:08:17 2019
@@ -328,7 +328,7 @@ void ObjFile::parse(bool ignoreComdats)
   for (const WasmEvent &e : wasmObj->events())
     events.emplace_back(make<InputEvent>(types[e.Type.SigIndex], e, this));
 
-  // Populate `Symbols` based on the WasmSymbols in the object.
+  // Populate `Symbols` based on the symbols in the object.
   symbols.reserve(wasmObj->getNumberOfSymbols());
   for (const SymbolRef &sym : wasmObj->symbols()) {
     const WasmSymbol &wasmSym = wasmObj->getWasmSymbol(sym.getRawDataRefImpl());

Modified: lld/trunk/wasm/MarkLive.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/wasm/MarkLive.cpp?rev=366192&r1=366191&r2=366192&view=diff
==============================================================================
--- lld/trunk/wasm/MarkLive.cpp (original)
+++ lld/trunk/wasm/MarkLive.cpp Tue Jul 16 01:08:17 2019
@@ -46,9 +46,9 @@ void lld::wasm::markLive() {
     if (InputChunk *chunk = sym->getChunk())
       q.push_back(chunk);
 
-    // The ctor functions are all referenced by the synthetic CallCtors
+    // The ctor functions are all referenced by the synthetic callCtors
     // function.  However, this function does not contain relocations so we
-    // have to manually mark the ctors as live if CallCtors itself is live.
+    // have to manually mark the ctors as live if callCtors itself is live.
     if (sym == WasmSym::callCtors) {
       if (config->passiveSegments)
         enqueue(WasmSym::initMemory);

Modified: lld/trunk/wasm/SymbolTable.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/wasm/SymbolTable.h?rev=366192&r1=366191&r2=366192&view=diff
==============================================================================
--- lld/trunk/wasm/SymbolTable.h (original)
+++ lld/trunk/wasm/SymbolTable.h Tue Jul 16 01:08:17 2019
@@ -98,7 +98,7 @@ private:
   InputFunction *replaceWithUnreachable(Symbol *sym, const WasmSignature &sig,
                                         StringRef debugName);
 
-  // Maps symbol names to index into the SymVector.  -1 means that symbols
+  // Maps symbol names to index into the symVector.  -1 means that symbols
   // is to not yet in the vector but it should have tracing enabled if it is
   // ever added.
   llvm::DenseMap<llvm::CachedHashStringRef, int> symMap;

Modified: lld/trunk/wasm/SyntheticSections.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/wasm/SyntheticSections.cpp?rev=366192&r1=366191&r2=366192&view=diff
==============================================================================
--- lld/trunk/wasm/SyntheticSections.cpp (original)
+++ lld/trunk/wasm/SyntheticSections.cpp Tue Jul 16 01:08:17 2019
@@ -474,8 +474,8 @@ void NameSection::writeBody() {
   SubSection sub(WASM_NAMES_FUNCTION);
   writeUleb128(sub.os, numNames(), "name count");
 
-  // Names must appear in function index order.  As it happens ImportedSymbols
-  // and InputFunctions are numbered in order with imported functions coming
+  // Names must appear in function index order.  As it happens importedSymbols
+  // and inputFunctions are numbered in order with imported functions coming
   // first.
   for (const Symbol *s : out.importSec->importedSymbols) {
     if (auto *f = dyn_cast<FunctionSymbol>(s)) {

Modified: lld/trunk/wasm/Writer.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/wasm/Writer.cpp?rev=366192&r1=366191&r2=366192&view=diff
==============================================================================
--- lld/trunk/wasm/Writer.cpp (original)
+++ lld/trunk/wasm/Writer.cpp Tue Jul 16 01:08:17 2019
@@ -191,7 +191,7 @@ void Writer::writeSections() {
 // to each of the input data sections as well as the explicit stack region.
 // The default memory layout is as follows, from low to high.
 //
-//  - initialized data (starting at Config->GlobalBase)
+//  - initialized data (starting at Config->globalBase)
 //  - BSS data (not currently implemented in llvm)
 //  - explicit stack (Config->ZStackSize)
 //  - heap start / unallocated




More information about the llvm-commits mailing list