[PATCH] D64750: [llvm-readelf] - Remove the precompiled binary from gnu-hash-symbols.test.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: test/tools/llvm-readobj/gnu-hash-symbols.test:1
-# RUN: llvm-readelf --hash-symbols %p/Inputs/dynamic-table-exe.x86 \
-# RUN:   | FileCheck %s --check-prefix HASH
+## Check llvm-readelf is able to dump the content of hash sections correctly.
 
----------------
Rename `gnu-hash-symbols.test` to `elf-hash-symbols.test` (or other better name)

This files tests both .hash (SysV hash) and .gnu.hash (GNU hash).


================
Comment at: test/tools/llvm-readobj/gnu-hash-symbols.test:32
+    Link:    .dynsym
+## Here and below it is a linker produced binary content for the symbols under the `DynamicSymbols` tag.
+    Content: '0300000006000000010000000000000000000000000000000500000004000000020000000000000003000000'
----------------
`Here and below it` -> `Here and below`

Or better, just explicitly mention that the contents of `.hash` and `.gnu.hash` were generated by a linker.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64750/new/

https://reviews.llvm.org/D64750