[PATCH] D63396: [WinEH] Allocate space in funclets stack to save XMM CSRs

[David Majnemer via Phabricator via llvm-commits]

majnemer added inline comments.


================
Comment at: llvm/lib/Target/X86/X86FrameLowering.cpp:1417
+            Offset = (FI - XMMFrameSlotOrigin - 1) * Size +
+                     (NumBytes & ~(Align - 1));
+            addRegOffset(BuildMI(MBB, MBBI, DL,
----------------
Seems easier to read as `alignDown(NumBytes, Align)`


================
Comment at: llvm/lib/Target/X86/X86FrameLowering.cpp:2051
+      continue;
+    // Since all registers have the same size, we just initialize once
+    if (Size == 0) {
----------------
Missing a period at the end of this sentence.


================
Comment at: llvm/lib/Target/X86/X86FrameLowering.cpp:2251-2252
+      }
+    }
+    else {
+      if (X86::GR64RegClass.contains(Reg) || X86::GR32RegClass.contains(Reg))
----------------
These should be on the same line.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63396/new/

https://reviews.llvm.org/D63396