[PATCH] D64779: [llvm-objdump] Emit warning if --start-address/--stop-address specify range outside file's address range.

[Yuanfang Chen via Phabricator via llvm-commits]

ychen marked 3 inline comments as done.
ychen added inline comments.


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:2016
+  if (const auto *Elf = dyn_cast<ELFObjectFileBase>(Obj)) {
+    if (Elf->getEType() == ELF::ET_EXEC ||
+        Elf->getEType() == ELF::ET_DYN)
----------------
MaskRay wrote:
> Why don't ET_CORE and ET_REL need the warning?
Section addresses in ET_REL files are not VMA, probably may not be very useful. ET_CORE could be here, I'm not sure its potential usefulness either. What's your opinion?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64779/new/

https://reviews.llvm.org/D64779