[PATCH] D64776: [WebAssembly] Compile all TLS on Emscripten as local-exec

[Heejin Ahn via Phabricator via llvm-commits]

aheejin added a comment.

- Not sure what this means. The CL description says it tries to compile things into local-exec, but what this CL does look like checking if a global var is local-exec and if not report an error.
- What is supposed to happen when the OS is not emscripten? If we don't support TLS in non-emscripten OSes regardless of its mode (local-exec or not), should we print an error in that case too?



================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyISelDAGToDAG.cpp:184
+    // with threads. Therefore, if we have thread-local storage, only the
+    // local-exec model is possible.
     if (GA->getGlobal()->getThreadLocalMode() !=
----------------
If this condition is to be removed once emscripten support dynamic linking with threads, rather than `XXX`, how about marking as `TODO Remove this condition once emscripten supports dynamic linking with threads` or something?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64776/new/

https://reviews.llvm.org/D64776