[PATCH] D64705: [WebAssembly] Add missing utility methods for exnref type

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 15 15:57:36 PDT 2019


aheejin marked an inline comment as done.
aheejin added inline comments.


================
Comment at: llvm/lib/Target/WebAssembly/MCTargetDesc/WebAssemblyMCTargetDesc.h:389
+  case WebAssembly::ARGUMENT_exnref:
+  case WebAssembly::ARGUMENT_exnref_S:
     return true;
----------------
tlively wrote:
> Maybe we really should think about adding a TableGen capability for this sort of thing. It is very inconvenient to have to find and update these utility methods every time we add new types.
I agree :(


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64705/new/

https://reviews.llvm.org/D64705





More information about the llvm-commits mailing list