[PATCH] D64176: [Bugpoint redesign] Added Pass to Remove Global Variables

[Diego Treviño via Phabricator via llvm-commits]

diegotf added inline comments.


================
Comment at: llvm/tools/llvm-reduce/deltas/Delta.h:67
+/// the CReduce, Delta, and Lithium projects.
+inline void runDeltaPass(
+    TestRunner &Test, int Targets,
----------------
dblaikie wrote:
> This 'inline' keyword probably needs to be removed. I'm surprised if this code links as-is (or compiles - some sort of warning/error like this:
> 
> inl.cpp:1:13: warning: inline function 'f' is not defined [-Wundefined-inline]
> inline void f();
>             ^
> inl.cpp:3:3: note: used here
>   f();
>   ^
> 
Yeah, I goofed up and uploaded a wrong commit


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64176/new/

https://reviews.llvm.org/D64176