[PATCH] D64757: [PEI] Don't re-allocate a pre-allocated stack protector slot

Arnaud A. de Grandmaison via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 15 13:48:55 PDT 2019


aadg added inline comments.


================
Comment at: llvm/lib/CodeGen/LocalStackSlotAllocation.cpp:202
   SmallSet<int, 16> ProtectedObjs;
-  if (MFI.getStackProtectorIndex() >= 0) {
+  if (MFI.hasStackProtectorIndex()) {
+    int StackProtectorFI = MFI.getStackProtectorIndex();
----------------
thegameg wrote:
> efriedma wrote:
> > Is this change a no-op?
> Yes, it just adds the assert.
Yes, this change is a no-op.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64757/new/

https://reviews.llvm.org/D64757





More information about the llvm-commits mailing list