[PATCH] D64707: [x86] try harder to form LEA from ADD to avoid flag conflicts (PR40483)

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 15 13:31:30 PDT 2019


spatel updated this revision to Diff 209944.
spatel marked an inline comment as done.
spatel added a comment.

Patch updated:

1. Check flag uses to avoid unintended transform.
2. Add TODO comment about && vs. ||.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64707/new/

https://reviews.llvm.org/D64707

Files:
  llvm/lib/Target/X86/X86ISelDAGToDAG.cpp
  llvm/test/CodeGen/X86/combine-sbb.ll
  llvm/test/CodeGen/X86/umulo-128-legalisation-lowering.ll
  llvm/test/CodeGen/X86/umulo-64-legalisation-lowering.ll
  llvm/test/CodeGen/X86/vec_umulo.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D64707.209944.patch
Type: text/x-patch
Size: 24436 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190715/72d5f0c2/attachment.bin>


More information about the llvm-commits mailing list