[PATCH] D64183: [NewPM] Port MachineModuleInfo to the new pass manager.

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 15 12:00:18 PDT 2019


arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: wdng.

LGTM with nits



================
Comment at: llvm/lib/CodeGen/MachineModuleInfo.cpp:363
+  MMI.TheModule = &M;
+  MMI.DbgInfoAvailable = !llvm::empty(M.debug_compile_units());
+  return MMI;
----------------
I don't think you need the llvm::


================
Comment at: llvm/tools/llc/llc.cpp:582-583
+      assert(MMIWP && "Forgot to create MMIWP?");
+          if (MIR->parseMachineFunctions(*M, MMIWP->getMMI()))
         return 1;
     }
----------------
Indentation broken


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64183/new/

https://reviews.llvm.org/D64183





More information about the llvm-commits mailing list