[PATCH] D64668: [llvm-lipo] Implement -info
Anusha Basana via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 15 11:16:16 PDT 2019
anushabasana added inline comments.
================
Comment at: llvm/tools/llvm-lipo/llvm-lipo.cpp:547
+ printInfo(InputBinaries);
+ break;
case LipoAction::ThinArch:
----------------
compnerd wrote:
> alexshap wrote:
> > compnerd wrote:
> > > Is there validation being applied here? I think that you should add a test case for invalid input as well (that is, pass ELF files to `lipo` and ensure that we handle that gracefully (right now, it feels like we may just abort?).
> > if I'm not mistaken `readInputBinaries` takes care of it, otherwise this would be reimplemented N times where N is the number of supported actions. Having an extra test of `-info` would not hurt though.
> Ah, okay, I was trying to see where that was called, I guess I just failed to see it. Yes, a test would be good still.
I added test info-invalid.test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64668/new/
https://reviews.llvm.org/D64668
More information about the llvm-commits
mailing list