[PATCH] D64185: [NewPM] Port FinalizeISel to the new pass manager.

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/FinalizeISel.h:25-30
+struct FinalizeISelPass : PassInfoMixin<FinalizeISelPass> {
+  PreservedAnalyses run(MachineFunction &MF, MachineFunctionAnalysisManager &);
+};
+} // namespace llvm
+
+#endif // LLVM_CODEGEN_FINALIZE_ISEL_H
----------------
Should these pass headers be sorted into an include/llvm/CodeGen/Passes directory?


================
Comment at: llvm/lib/Passes/PassRegistry.def:320
+MACHINE_FUNCTION_PASS("finalize-isel", FinalizeISelPass())
+MACHINE_FUNCTION_PASS("machine-cse", MachineCSEPass())
 #undef MACHINE_FUNCTION_PASS
----------------
Machine CSE doesn't belong in this patch?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64185/new/

https://reviews.llvm.org/D64185