[PATCH] D64095: SVFS implementation according to RFC: Interface user provided vector functions with the vectorizer.
Sumedh Arani via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 15 09:50:40 PDT 2019
aranisumedh added inline comments.
================
Comment at: llvm/include/llvm/Analysis/SearchVectorFunctionSystem.h:110
+ .Case("Us", ParameterKind::OMP_LinearUValPos)
+ .Case("u", ParameterKind::OMP_Uniform);
+
----------------
jdoerfert wrote:
> What is the default here? What happens for bad inputs?
Should I add an assert before the StringSwitch?
Or add OMP_Unknown to handle such cases?
================
Comment at: llvm/include/llvm/Analysis/SearchVectorFunctionSystem.h:216
+ }
+};
+
----------------
jdoerfert wrote:
> It seems the new pass manager interface is missing.
Could you share pointers to how to add a new pass using the new pass manager interface?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64095/new/
https://reviews.llvm.org/D64095
More information about the llvm-commits
mailing list