[PATCH] D64706: [tools] [llvm-objdump] Default to reading from stdin not a.out
Alex Brachet via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 15 09:19:46 PDT 2019
abrachet added a comment.
We could do:
if (InputFilenames.empty())
InputFilenames.push_back(StandardInIsUserInput() ? "a.out" : "-");
This behavior would be very confusing though. Not to mention wouldn't even work always (doesn't for lit which seemingly redirects something to stdin).
FWIW, @MaskRay pointed out that `addr2line` defaults to a.out but `llvm-addr2line` doesn't. Since that thread `llvm-nm` also defaults to reading from standard input while `nm` uses a.out, see rL365889 <https://reviews.llvm.org/rL365889>. I have no preference I don't mind going back on this or rL365889 <https://reviews.llvm.org/rL365889>.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64706/new/
https://reviews.llvm.org/D64706
More information about the llvm-commits
mailing list