[PATCH] D64589: [UpdateTestChecks] Emit warning when invalid value for -check-prefix(es) option

[Dávid Bolvanský via Phabricator via llvm-commits]

xbolva00 marked 2 inline comments as done.
xbolva00 added inline comments.


================
Comment at: utils/UpdateTestChecks/common.py:287
+        if prefixes.count(prefix) > 1:
+          print('WARNING: Supplied prefix \'%s\' is not unique in prefix list.' %
+                (prefix,), file=sys.stderr)
----------------
gbedwell wrote:
> A very nitpicky and minor style nit, but you can contain single quotes in double quoted strings and double quotes in single quotes strings, so it may be more readable like this as you don't have to escape anything.
> 
> 
> ```
> print('WARNING: Supplied prefix "%s" is not unique in prefix list.'
> ```
> 
> or:
> 
> ```
> print("WARNING: Supplied prefix '%s' is not unique in prefix list."
> ```
> 
+1

Yeah, this looks better.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64589/new/

https://reviews.llvm.org/D64589