[PATCH] D58453: [DebugInfo][CGP] Limit placeDbgValues movement of dbg.value intrinsics

Yury Delendik via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 15 07:52:19 PDT 2019


yurydelendik added a comment.

In D58453#1585436 <https://reviews.llvm.org/D58453#1585436>, @jmorse wrote:

> the `WebAssemblyDebugValueManager` constructor could just apply an additional filter on collected DbgValues, that the LiveInterval/ValueNumber the DBG_VALUE refers to is the defining instruction.


Sounds good. That was the one reason for existence of `WebAssemblyDebugValueManager`. I would like not to change the test case, but fix the WebAssemblyDebugValueManager's logic here or in a different patch. Let me know if I need to follow up if the latter.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58453/new/

https://reviews.llvm.org/D58453





More information about the llvm-commits mailing list