[PATCH] D64622: [DWARF] Fix the reserved values for unit length in DWARFDebugLine.

[Paul Robinson via Phabricator via llvm-commits]

probinson added a comment.

In D64622#1584208 <https://reviews.llvm.org/D64622#1584208>, @ikudrin wrote:

> I mean, the purposes for the patches are different. This one fixes an existing flaw while your suggestion improves code quality. It is usually better not to intermix such different aims in one patch, no?


There is no hard-and-fast rule about this; the project does prefer incremental changes, but the determination of what "size" increment to perform is not strictly defined.  Personally I would do it all at once, with the stated purpose being to clean up the use of magic numbers (some of which happen to be incorrect).  If you want to work in smaller increments, that's okay too.

I see that there are no tests verifying that DWARFDebugLine handles the invalid length correctly (assuming you ran the tests and none failed), so please add one.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64622/new/

https://reviews.llvm.org/D64622