[PATCH] D64713: [InstCombine] X *fast (C ? 1.0 : 0.0) -> C ? X : 0.0

Mon Jul 15 03:01:55 PDT 2019

foad added a comment.

In D64713#1585078 <https://reviews.llvm.org/D64713#1585078>, @xbolva00 wrote:

> I think we need a few more tests here
>
> a) vector tests
>  b) 'extra use' tests
>  c) negative tests

a) I've added one.
b) The patch doesn't introduce any new hasOneUse() tests. Do you think it should?
c) There are infinitely many expressions not optimized by this pattern :) Can you give an example of the kind of thing you're thinking of?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64713/new/

https://reviews.llvm.org/D64713