[PATCH] D64713: [InstCombine] X *fast (C ? 1.0 : 0.0) -> C ? X : 0.0

Mon Jul 15 02:54:13 PDT 2019

foad added a comment.

In D64713#1585080 <https://reviews.llvm.org/D64713#1585080>, @xbolva00 wrote:

> Not sure how other reviewers, but I consider the use of 'C' as confusing here, since 'C' is usually a constant. I would recommend to avoid 'C', if it is not a constant.
>
> Edit: As I see, original code also used 'C', so feel free to ignore me :)

Right, and since the code uses all of A B C D E F, I think it's reasonably clear that none of them are meant to stand for anything in particular.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64713/new/

https://reviews.llvm.org/D64713