[PATCH] D62462: [llvm-objdump] Add warning messages if disassembly + source for problematic inputs

[Mike Pozulp via Phabricator via llvm-commits]

mmpozulp marked an inline comment as done.
mmpozulp added inline comments.


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:621
+    if(!WarnedNoDebugInfo) {
+      warn("unable to find debug information for " + ObjectFilename);
+      WarnedNoDebugInfo = true;
----------------
jhenderson wrote:
> It's probably worth sticking with the "failed to parse..." phrasing in case there was a genuine problem parsing it:
> "failed to parse debug information for " + ObjectFilename.
> 
> Bonus points if it makes sense to use the infromation in the ExpectedLinkInfo error in this case.
I ran it in lldb and observed that in this case `ExpectedLineInfo` has no error, so according to the [[ http://llvm.org/docs/ProgrammersManual.html#recoverable-errors | programmer's manual ]] all it can tell us is "success":

> If an Expected<T> value is in success mode then the takeError() method will return a success value.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62462/new/

https://reviews.llvm.org/D62462