[PATCH] D64618: [Loop Peeling] Fix the bug with IDom setting for exit loops

Serguei Katkov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jul 14 22:09:24 PDT 2019


skatkov marked an inline comment as done.
skatkov added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/LoopUnrollPeel.cpp:588
+  if (DT)
+    for (auto Edge : ExitEdges) {
+      if (ExitIDom.count(Edge.second))
----------------
reames wrote:
> Please add an assert that L has dedicated exits, because that's the precondition for your dominance fact.
In the beginning of this method we have an assert that we canPeel which returns true only if loop is in simplify form what includes the check that all exits are dedicated.

It is to far so I'm ok to add an assert here as well.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64618/new/

https://reviews.llvm.org/D64618





More information about the llvm-commits mailing list