[PATCH] D64709: [AMDGPU] fixed scheduler crash in gfx908

Austin Kerbow via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jul 14 12:50:06 PDT 2019


kerbowa added inline comments.


================
Comment at: lib/Target/AMDGPU/AMDGPUSubtarget.cpp:769
+    const MachineInstr *MI = SU->getInstr();
+    return MI && TII->isSALU(*MI) && !MI->isTerminator();
   }
----------------
rampitec wrote:
> kerbowa wrote:
> > There is SUnit::isInstr() also
> It's actually very strange to see anything but MI in the PostRA scheduler.
Yeah I just meant as a null check.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64709/new/

https://reviews.llvm.org/D64709





More information about the llvm-commits mailing list