[PATCH] D60389: FileCheck [9/12]: Add support for matching formats

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/unittests/Support/FileCheckTest.cpp:74
+  auto FoobarExpr = FileCheckNumExpr(Binop, FmtUnsigned);
   FileCheckNumericVariable FoobarVar =
+      FileCheckNumericVariable(2, "FOOBAR", &FoobarExpr);
----------------
thopre wrote:
> MaskRay wrote:
> > `FileCheckNumericVariable FoobarVar(...)` or `FileCheckNumericVariable FoobarVar{...}`
> Is that the expected usage in LLVM? I've already added quite a lot of occurences in existing code, that would need to be taken care in a separate patch IMO.
Yes. In addition, I think `Ctor A = Ctor(arg1, arg2);` is a very uncommon pattern in C++.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60389/new/

https://reviews.llvm.org/D60389