[PATCH] D64663: Extend function attributes bitset size from 64 to 96.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.

Ah, I missed that.

LGTM



================
Comment at: llvm/lib/IR/AttributeImpl.h:250
+  /// Bitset with a bit for each available attribute Attribute::AttrKind.
+  uint8_t AvailableFunctionAttrs[12];
 
----------------
jdoerfert wrote:
> vitalybuka wrote:
> > std::bitset?
> We also have a `llvm::SmallBitVector`. If we keep a fixed size encoding we should add a (static) assert so it'll break in a informative manner once the new limit is reached.
Nit: maybe do `uint8_t AvailableFunctionAttrs[12] = {};` to avoid needing to put the initializer in the ctor.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64663/new/

https://reviews.llvm.org/D64663