[PATCH] D64285: [InstCombine] Fold select (icmp sgt x, -1), lshr (X, Y), ashr (X, Y) to ashr (X, Y))

Dávid Bolvanský via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 12 14:16:07 PDT 2019


xbolva00 added a comment.

In D64285#1583596 <https://reviews.llvm.org/D64285#1583596>, @craig.topper wrote:

> In D64285#1583589 <https://reviews.llvm.org/D64285#1583589>, @xbolva00 wrote:
>
> > if (Bitwidth == 0) {
> >
> >     IC->dump();
> >   }
> >   
> >
> > %cmp.i = icmp ne %struct.LIST_HELP* %List.addr.0, null
>
>
> Yep, its a pointer. Just disable the transform if !CmpRHs->getType()->isIntOrIntVectorTy()


Thanks! Commited fast fix. And thanks @vitalybuka for reporting this issue.

rL365959 <https://reviews.llvm.org/rL365959>


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64285/new/

https://reviews.llvm.org/D64285





More information about the llvm-commits mailing list