[PATCH] D64650: Add a TargetMachineVerifier that runs along with the existing MachineVerifier

Fri Jul 12 13:52:38 PDT 2019

arsenm added a comment.

In D64650#1583533 <https://reviews.llvm.org/D64650#1583533>, @dsanders wrote:

> In D64650#1583208 <https://reviews.llvm.org/D64650#1583208>, @arsenm wrote:
>
> > The current target verification problems I have are:
> >
> > - Verifying legal register bank mappings, so I don't have to defend against them in InstructionSelect
> > - Verifying G_INTRINSIC operand types and numbers. There's missing API to do this.
>

The only Intrinsic:: functions only deal with IR-level information. I didn't see a way to figure out the argument list without getting a concrete Function declaration. That would require converting from the argument LLTs to Type*, but you also don't know the context of which operands are needed for mangling without hardcoding it for specific intrinsics.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64650/new/

https://reviews.llvm.org/D64650