[PATCH] D64663: Extend function attributes bitset size from 64 to 96.

Fri Jul 12 13:49:37 PDT 2019

jdoerfert added a comment.

In D64663#1583507 <https://reviews.llvm.org/D64663#1583507>, @eugenis wrote:

> It's sanitize_memtag in the child revision.
>  Actually, we were fine without this until your change on Jule 10 pushed our pending attribute over the limit :)

It seems it's my fault...

notsmartman <https://reviews.llvm.org/file/data/mywc3jhsqtj2lnwtkfvt/PHID-FILE-4hqiydtbdxqhew4z4yp2/meme-notsmartman>

(sorry for derailing this, always wanted to try these memes they added)

================
Comment at: llvm/lib/IR/AttributeImpl.h:250
+  /// Bitset with a bit for each available attribute Attribute::AttrKind.
+  uint8_t AvailableFunctionAttrs[12];

----------------
vitalybuka wrote:
> std::bitset?
We also have a `llvm::SmallBitVector`. If we keep a fixed size encoding we should add a (static) assert so it'll break in a informative manner once the new limit is reached.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64663/new/

https://reviews.llvm.org/D64663