[PATCH] D64601: [MemorySSA] Use SetVector to avoid nondeterminism.

[Alina Sbirlea via Phabricator via llvm-commits]

asbirlea added a comment.

I don't know if a bot exists with LLVM_ENABLE_REVERSE_ITERATION set to true, but if it does, then the check I proposed for the uselist order would likely fail, no?

  ; CHECK: uselistorder i16 0, { 3, 2, 4, 1, 5, 0, 6 }



> Does this test case exercise/justify all the container changes in this patch?

The test shows the need for an ordered container in `removeBlocks`. The patch changes all callsites for this method, and the sets it changes are also not used for much except the call to `removeBlocks`, so I think it should be fine.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64601/new/

https://reviews.llvm.org/D64601