[PATCH] D64111: Add getMostFrequentByte and use for isBytewiseValue implementation

Vitaly Buka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 12 13:19:52 PDT 2019


vitalybuka marked an inline comment as done.
vitalybuka added inline comments.


================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:3182
   if (isa<UndefValue>(V))
-    return UndefInt8;
+    return;
 
----------------
jfb wrote:
> Should `Undef` count as `Other`? Or have its own count?
Undef means we don't care what it's there, so we can fill we any pattern.
Other counts bytes which are different from most frequent value and will have to be fixed, e.g. after memset


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64111/new/

https://reviews.llvm.org/D64111





More information about the llvm-commits mailing list