[PATCH] D64650: Add a TargetMachineVerifier that runs along with the existing MachineVerifier

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: lib/Target/AArch64/AArch64MachineVerifier.cpp:79-92
+void AArch64MachineVerifier::verifyMI(const MachineFunction &MF,
+                                      const MachineBasicBlock &MBB,
+                                      const MachineInstr &MI,
+                                      const char *CallBanner) {
+  switch (MI.getOpcode()) {
+  case AArch64::SBFMWri:
+  case AArch64::UBFMWri:
----------------
While I do think there is a need for a target verifier pass, you don't need it to verify instruction level things like this. You can already do that in TargetInstrInfo::verifyInstruction


================
Comment at: unittests/CodeGen/GlobalISel/PatternMatchTest.cpp:531
+  MI.getOperand(2).setImm(64);
+  ASSERT_FALSE(MF->verify(nullptr, "Banner", false));
+}
----------------
EXPECT_FALSE


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64650/new/

https://reviews.llvm.org/D64650