[llvm] r365925 - [Attributor] Removing unnecessary `virtual` keywords.
Stefan Stipanovic via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 12 10:42:14 PDT 2019
Author: sstefan
Date: Fri Jul 12 10:42:14 2019
New Revision: 365925
URL: http://llvm.org/viewvc/llvm-project?rev=365925&view=rev
Log:
[Attributor] Removing unnecessary `virtual` keywords.
Some function in the Attributor framework are unnecessarily
marked virtual. This patch removes virtual keyword
Reviewers: jdoerfert
Subscribers: hiraditya, llvm-commits
Differential Revision: https://reviews.llvm.org/D64637
Modified:
llvm/trunk/include/llvm/Transforms/IPO/Attributor.h
llvm/trunk/lib/Transforms/IPO/Attributor.cpp
Modified: llvm/trunk/include/llvm/Transforms/IPO/Attributor.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Transforms/IPO/Attributor.h?rev=365925&r1=365924&r2=365925&view=diff
==============================================================================
--- llvm/trunk/include/llvm/Transforms/IPO/Attributor.h (original)
+++ llvm/trunk/include/llvm/Transforms/IPO/Attributor.h Fri Jul 12 10:42:14 2019
@@ -657,7 +657,7 @@ struct AAReturnedValues : public Abstrac
checkForallReturnedValues(std::function<bool(Value &)> &Pred) const = 0;
/// See AbstractAttribute::getAttrKind()
- virtual Attribute::AttrKind getAttrKind() const override { return ID; }
+ Attribute::AttrKind getAttrKind() const override { return ID; }
/// The identifier used by the Attributor for this class of attributes.
static constexpr Attribute::AttrKind ID = Attribute::Returned;
@@ -669,7 +669,7 @@ struct AANoUnwind : public AbstractAttri
: AbstractAttribute(V, InfoCache) {}
/// See AbstractAttribute::getAttrKind()/
- virtual Attribute::AttrKind getAttrKind() const override { return ID; }
+ Attribute::AttrKind getAttrKind() const override { return ID; }
static constexpr Attribute::AttrKind ID = Attribute::NoUnwind;
@@ -686,7 +686,7 @@ struct AANoSync : public AbstractAttribu
: AbstractAttribute(V, InfoCache) {}
/// See AbstractAttribute::getAttrKind().
- virtual Attribute::AttrKind getAttrKind() const override {
+ Attribute::AttrKind getAttrKind() const override {
return ID;
}
Modified: llvm/trunk/lib/Transforms/IPO/Attributor.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/IPO/Attributor.cpp?rev=365925&r1=365924&r2=365925&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/IPO/Attributor.cpp (original)
+++ llvm/trunk/lib/Transforms/IPO/Attributor.cpp Fri Jul 12 10:42:14 2019
@@ -359,22 +359,22 @@ struct AANoUnwindFunction : AANoUnwind,
/// }
/// See AbstractAttribute::getManifestPosition().
- virtual ManifestPosition getManifestPosition() const override {
+ ManifestPosition getManifestPosition() const override {
return MP_FUNCTION;
}
- virtual const std::string getAsStr() const override {
+ const std::string getAsStr() const override {
return getAssumed() ? "nounwind" : "may-unwind";
}
/// See AbstractAttribute::updateImpl(...).
- virtual ChangeStatus updateImpl(Attributor &A) override;
+ ChangeStatus updateImpl(Attributor &A) override;
/// See AANoUnwind::isAssumedNoUnwind().
- virtual bool isAssumedNoUnwind() const override { return getAssumed(); }
+ bool isAssumedNoUnwind() const override { return getAssumed(); }
/// See AANoUnwind::isKnownNoUnwind().
- virtual bool isKnownNoUnwind() const override { return getKnown(); }
+ bool isKnownNoUnwind() const override { return getKnown(); }
};
ChangeStatus AANoUnwindFunction::updateImpl(Attributor &A) {
@@ -491,21 +491,21 @@ public:
}
/// See AbstractAttribute::manifest(...).
- virtual ChangeStatus manifest(Attributor &A) override;
+ ChangeStatus manifest(Attributor &A) override;
/// See AbstractAttribute::getState(...).
- virtual AbstractState &getState() override { return *this; }
+ AbstractState &getState() override { return *this; }
/// See AbstractAttribute::getState(...).
- virtual const AbstractState &getState() const override { return *this; }
+ const AbstractState &getState() const override { return *this; }
/// See AbstractAttribute::getManifestPosition().
- virtual ManifestPosition getManifestPosition() const override {
+ ManifestPosition getManifestPosition() const override {
return MP_ARGUMENT;
}
/// See AbstractAttribute::updateImpl(Attributor &A).
- virtual ChangeStatus updateImpl(Attributor &A) override;
+ ChangeStatus updateImpl(Attributor &A) override;
/// Return the number of potential return values, -1 if unknown.
size_t getNumReturnValues() const {
@@ -518,11 +518,11 @@ public:
Optional<Value *> getAssumedUniqueReturnValue() const;
/// See AbstractState::checkForallReturnedValues(...).
- virtual bool
+ bool
checkForallReturnedValues(std::function<bool(Value &)> &Pred) const override;
/// Pretty print the attribute similar to the IR representation.
- virtual const std::string getAsStr() const override;
+ const std::string getAsStr() const override;
/// See AbstractState::isAtFixpoint().
bool isAtFixpoint() const override { return IsFixed; }
More information about the llvm-commits
mailing list