[PATCH] D64595: [Debuginfo][SROA] Need to handle dbg.value in SROA pass.

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere added a comment.

Few nits inline



================
Comment at: llvm/lib/Transforms/Scalar/SROA.cpp:4245
+/// Finds intrinsics declaring local variables as living in the memory
+/// that 'V' points to and intrinsics specifing usages of values which
+/// living in the memory that 'V' points to. Put only one relevant
----------------
s/specifing/specifying/


================
Comment at: llvm/lib/Transforms/Scalar/SROA.cpp:4246
+/// that 'V' points to and intrinsics specifing usages of values which
+/// living in the memory that 'V' points to. Put only one relevant
+/// intrinsic for each variable. Result may include a mix of dbg.declare,
----------------
... are living ...


================
Comment at: llvm/lib/Transforms/Scalar/SROA.cpp:4248
+/// intrinsic for each variable. Result may include a mix of dbg.declare,
+///  dbg.addr and dbg.value intrinsics.
+
----------------
Spurious space


================
Comment at: llvm/lib/Transforms/Scalar/SROA.cpp:4249
+///  dbg.addr and dbg.value intrinsics.
+
+void findDeclarations(SmallVectorImpl<DbgVariableIntrinsic *> &Declarations,
----------------
Spurious newline. I guess doxygen is still smart enough to connect it to the next function, but still better to remove it. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64595/new/

https://reviews.llvm.org/D64595