[PATCH] D64636: [AMDGPU] Restrict v_cndmask_b32 abs/neg modifiers to f32

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 12 07:53:16 PDT 2019


foad created this revision.
foad added reviewers: arsenm, hakzsam.
Herald added subscribers: hiraditya, t-tye, tpr, dstuttard, yaxunl, nhaehnle, wdng, jvesely, kzhuravl.
Herald added a project: LLVM.

D64497 <https://reviews.llvm.org/D64497> allowed abs/neg source modifiers on v_cndmask_b32 but it doesn't
make any sense to apply them to f16 operands; they would interpret the
bits of the value as an f32, giving nonsensical results. This patch
restricts them to f32 operands.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D64636

Files:
  llvm/lib/Target/AMDGPU/AMDGPUISelDAGToDAG.cpp
  llvm/lib/Target/AMDGPU/SIInstrInfo.td
  llvm/lib/Target/AMDGPU/SIInstructions.td
  llvm/test/CodeGen/AMDGPU/v_cndmask.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D64636.209483.patch
Type: text/x-patch
Size: 5208 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190712/d7f67fbc/attachment.bin>


More information about the llvm-commits mailing list