[PATCH] D64612: [WebAssembly] i32.const operands should be signed

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added inline comments.


================
Comment at: lld/test/wasm/data-segments.ll:44
 @b = hidden global [8 x i8] c"goodbye\00", align 1
- at c = hidden global [9 x i8] c"whatever\00", align 1
+ at c = hidden global [10000 x i8] zeroinitializer, align 1
 @d = hidden global i32 42, align 4
----------------
How does this change test the logic change?   Seems like 10000 isn't large enough to trigger the binaryen crash?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64612/new/

https://reviews.llvm.org/D64612