[PATCH] D62462: [llvm-objdump] Add warning messages if disassembly + source for problematic inputs

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Cool, nearly there. Just one more suggestion.



================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:621
+    if(!WarnedNoDebugInfo) {
+      warn("unable to find debug information for " + ObjectFilename);
+      WarnedNoDebugInfo = true;
----------------
It's probably worth sticking with the "failed to parse..." phrasing in case there was a genuine problem parsing it:
"failed to parse debug information for " + ObjectFilename.

Bonus points if it makes sense to use the infromation in the ExpectedLinkInfo error in this case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62462/new/

https://reviews.llvm.org/D62462