[PATCH] D63923: [Loop Peeling] Enable peeling for loops with multiple exits

Serguei Katkov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 11 22:45:43 PDT 2019


skatkov updated this revision to Diff 209416.
skatkov added a comment.

Handled Philip's comments.

I decided to avoid introduction of utility function for check that all side exits
end up with deopt. The current code with all_of looks short enough and clear
to understand. At the same time, the case in LoopUnrollruntime is more narrow
due to it supports only one side exits, so updating that case to use the same utility
function does not improve readability from my view.

Please take a look.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63923/new/

https://reviews.llvm.org/D63923

Files:
  llvm/lib/Transforms/Utils/LoopUnroll.cpp
  llvm/lib/Transforms/Utils/LoopUnrollPeel.cpp
  llvm/test/Transforms/LoopUnroll/peel-loop-pgo-deopt.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D63923.209416.patch
Type: text/x-patch
Size: 5663 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190712/5b848c0c/attachment.bin>


More information about the llvm-commits mailing list