[PATCH] D64427: LLVM Test-Suite: Support Cross-Compilation and Cross-execution targeting arm64-linux-android

Thu Jul 11 15:50:36 PDT 2019

ziangwan marked 3 inline comments as done.
ziangwan added inline comments.

================
Comment at: cmake/caches/target-arm64-android-template.sh:8
+# REQUIRED: path to android ndk that contains necessary header files and libraries
+ANDROID_NDK_LOCATION="/data/local/tmp/docspace/android-ndk-r20"
+# REQUIRED: path to llvm build bin
----------------
danalbert wrote:
> ziangwan wrote:
> > danalbert wrote:
> > > (why is this "doc" space?)
> > > 
> > > Should probably keep everything under a common subdirectory to avoid any collisions. `/data/local/tmp/llvm-test-suite/...`
> > > 
> > > Is it actually necessary to push the NDK to the device? None of the toolchains are built to run on Android. I can't even think of what use the sysroot would be.
> > "docspace" is an arbitrary name I use for myself. You don't have to use "docspace".
> > 
> > Yes, you can use `/data/local/tmp/llvm-test-suite/..` as your path. This shell script is just a template.
> > 
> > I am not pushing the whole NDK to the device. It is only used during compilation.
> Then why is it a `/data` path? That's part of the Android file system. Mirroring that on the host requires root.
I will follow Peter's advice. I will do a string replace of host-side path with device-side path.

Repository:
  rT test-suite

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64427/new/

https://reviews.llvm.org/D64427