[PATCH] D64111: Add getMostFrequentByte and use for isBytewiseValue implementation
    Evgenii Stepanov via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Thu Jul 11 14:55:26 PDT 2019
    
    
  
eugenis added a comment.
I'm a bit worried about performance implications.
isBytewiseValue is now doing some clearly unnecessary work.
Could you sanity check that it does not affect compilation times?
================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:3172
+struct ValueHistogram {
+  uint64_t Values[256] = {};
+  uint64_t Other = 0;
----------------
use std::array
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64111/new/
https://reviews.llvm.org/D64111
    
    
More information about the llvm-commits
mailing list