[PATCH] D59553: [LLD][ELF][DebugInfo] llvm-symbolizer shows incorrect source line info if --gc-sections used

Alexey Lapshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 11 14:17:17 PDT 2019


avl added a comment.

In D59553#1526993 <https://reviews.llvm.org/D59553#1526993>, @ruiu wrote:

> I'm fine with this patch. We've discussed a lot about what is a desirable value for a "null" for debug info, but looks like as long as it does not appear as a valid address, it should be fine.
>
> Is Eric fine with this?


@ruiu , It looks like @echristo does not follow this review. Would you mind to approve it, please ?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59553/new/

https://reviews.llvm.org/D59553





More information about the llvm-commits mailing list