[PATCH] D63097: [cmake] Don't add Support/Testing library if tests are not included

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 11 13:59:41 PDT 2019


lebedev.ri added inline comments.


================
Comment at: lib/CMakeLists.txt:30
 add_subdirectory(XRay)
-add_subdirectory(Testing)
+if (${LLVM_INCLUDE_TESTING})
+  add_subdirectory(Testing)
----------------
tra wrote:
> Where does LLVM_INCLUDE_TESTING come from?
> It should probably be an option() in llvm/CMakeLists.txt
`if(LLVM_INCLUDE_TESTS)` should work just fine too, and is cleaner.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63097/new/

https://reviews.llvm.org/D63097





More information about the llvm-commits mailing list