[PATCH] D64470: [Object/ELF] - Improve error reporting for notes.

[George Rimar via Phabricator via llvm-commits]

grimar updated this revision to Diff 209288.
grimar added a comment.
This revision is now accepted and ready to land.

- Fixed the reason of BB failture.

So the issue was in the original code. `notes_begin()` accepts a reference to
the `Error` object. When `Error` assignment operation happens it asserts with 
`LLVM_ENABLE_ABI_BREAKING_CHECKS` because default `Error::success()` value
is never checked. Previously we just did not have a test case for such scenario
and so issue simply was never triggered.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64470/new/

https://reviews.llvm.org/D64470

Files:
  include/llvm/Object/ELF.h
  test/tools/llvm-readobj/gnu-notes.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D64470.209288.patch
Type: text/x-patch
Size: 10623 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190711/bc7c23e1/attachment.bin>