[PATCH] D64505: [Support] Move the static initializer install_out_memory_new_handler to InitLLVM

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 11 11:39:14 PDT 2019


rnk added a comment.

In D64505#1580928 <https://reviews.llvm.org/D64505#1580928>, @jfb wrote:

> Let me rephrase: does it ever make sense to call `InitLLVM` if there's already a new handler installed? Or is it always a sign of trouble if that's done?


I think it would be reasonable to assert that get_new_handler returns null when we install ours. It's also worth checking the documentation for InitLLVM again:
http://llvm-cs.pcc.me.uk/include/llvm/Support/InitLLVM.h#19
We can mention the new handler after the signal handler there.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64505/new/

https://reviews.llvm.org/D64505





More information about the llvm-commits mailing list