[PATCH] D63604: [Attributor] Deduce "nonnull" attribute
Hideto Ueno via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 11 11:12:30 PDT 2019
uenoku marked an inline comment as done.
uenoku added inline comments.
================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:854
+ Value &V = *getAssociatedValue();
+
+ auto *AANonNull = A.getAAFor<AANonNullImpl>(*this, V);
----------------
jdoerfert wrote:
> uenoku wrote:
> > jdoerfert wrote:
> > > `isKnowNonNull(&V, ...)` ?
> > >`isKnowNonNull(&V, ...)`?
> >
> > Could you explain more detail?
> >
> >
> >
> >
> Sorry. Any reason you do not use the `isKnownNonNull` functionality here (as you did above)? The check for an `AANonNullImpl` attribute will only succeed if the values is a call or argument.
I understand you are saying about `isKnownNonZero` :).
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63604/new/
https://reviews.llvm.org/D63604
More information about the llvm-commits
mailing list