[PATCH] D60388: FileCheck [8/12]: Define numeric var from expr

[Thomas Preud'homme via Phabricator via llvm-commits]

thopre added inline comments.


================
Comment at: llvm/include/llvm/Support/FileCheck.h:578
+                      FileCheckPatternContext *Context, const SourceMgr &SM);
+  /// Parses \p Expr for a binary operation at line \p LineNumber, where 0
+  /// indicates the command-line. The left operand of this binary operation is
----------------
arichardson wrote:
> Here and in the other functions: maybe use Optional<size_t> instead of a magic value of zero for line numbers?
> I don't have a strong opinion here, I just think it might make it more obvious that the line number can also not be a line number but rather "this came from the command line".
I'll schedule a patch to that effect before this one since changing this might touch some area not currently touched by this patch. Keeping your comment open for now, will close it once I've added the patch to the patch series.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60388/new/

https://reviews.llvm.org/D60388