[PATCH] D62766: [Attributor] Deduce "nosync" function attribute.

[Matt Arsenault via Phabricator via llvm-commits]

arsenm accepted this revision.
arsenm added a comment.
Herald added a subscriber: wdng.

LGTM with nits



================
Comment at: llvm/include/llvm/Transforms/IPO/Attributor.h:689
+  /// See AbstractAttribute::getAttrKind().
+  virtual Attribute::AttrKind getAttrKind() const override {
+    return ID;
----------------
Don't need virtual, only override


================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:745
+
+  virtual const std::string getAsStr() const override {
+    return getAssumed() ? "nosync" : "may-sync";
----------------
No virtual necessary (and for the rest of the overrides)


================
Comment at: llvm/test/Bitcode/attributes.ll:367
+define void @f62() nosync
+{
+  ret void
----------------
Brace placement


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62766/new/

https://reviews.llvm.org/D62766