[PATCH] D64551: [X86] EltsFromConsecutiveLoads - support common source loads

Thu Jul 11 05:24:42 PDT 2019

lebedev.ri added a comment.

In D64551#1580320 <https://reviews.llvm.org/D64551#1580320>, @RKSimon wrote:

> > Is that what `if (LD->getChain() != Base->getChain()) return false;` does?
>
> Yes, chains will handle these kinds of dependencies

Great to know! No other comments from me.

> - do you want me to add that test ?

Hmm, i'm not fully sure it's really useful as-is - in *that* case we can just reorder that store before these loads, so *that* case could still be folded.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64551/new/

https://reviews.llvm.org/D64551