[PATCH] D64533: [IndVars] Special case the problematic (gep inbounds p, iv == nullptr) problem (pr42357)

Noel Grandin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 11 04:59:22 PDT 2019


grandinj added inline comments.


================
Comment at: lib/Transforms/Utils/SimplifyIndVar.cpp:195
+  // 
+  // Note: We handle this explicitly in terms of values as SCEV looses the
+  //  inbounds facts on the GEP when forming the SCEV expressions.  If we don't
----------------
looses->loses


================
Comment at: lib/Transforms/Utils/SimplifyIndVar.cpp:198
+  //  special case this here, we'll LFTR the expression into a form where due
+  //  to the lost inbounds, we'll loose the ability to discharge the check.
+  if (auto *GEP = dyn_cast<GetElementPtrInst>(IVOperand))
----------------
loose->lose


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64533/new/

https://reviews.llvm.org/D64533





More information about the llvm-commits mailing list