[PATCH] D59208: [DAGCombiner] fold (addcarry (xor a, -1), b, c) -> (subcarry b, a, !c) and flip carry.
Amaury SECHET via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 11 04:39:39 PDT 2019
- Previous message: [PATCH] D59208: [DAGCombiner] fold (addcarry (xor a, -1), b, c) -> (subcarry b, a, !c) and flip carry.
- Next message: [PATCH] D59208: [DAGCombiner] fold (addcarry (xor a, -1), b, c) -> (subcarry b, a, !c) and flip carry.
- Messages sorted by:
[ date ]
[ thread ]
[ subject ]
[ author ]
deadalnix marked an inline comment as done.
deadalnix added inline comments.
================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:2718
+ const TargetLowering &TLI,
+ bool Force = false) {
+ if (Force && isa<ConstantSDNode>(V))
----------------
RKSimon wrote:
> It's probably better for Force not to have a default value?
I don't feel strongly either way so I'll remove the default value.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59208/new/
https://reviews.llvm.org/D59208
- Previous message: [PATCH] D59208: [DAGCombiner] fold (addcarry (xor a, -1), b, c) -> (subcarry b, a, !c) and flip carry.
- Next message: [PATCH] D59208: [DAGCombiner] fold (addcarry (xor a, -1), b, c) -> (subcarry b, a, !c) and flip carry.
- Messages sorted by:
[ date ]
[ thread ]
[ subject ]
[ author ]
More information about the llvm-commits
mailing list